Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TC-284] Strip "actionable" query strings #1065

Closed
limited opened this issue Aug 29, 2017 · 3 comments · Fixed by #6019
Closed

[TC-284] Strip "actionable" query strings #1065

limited opened this issue Aug 29, 2017 · 3 comments · Fixed by #6019
Labels
low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior tech debt rework due to choosing easy/limited solution Traffic Router related to Traffic Router

Comments

@limited
Copy link
Contributor

limited commented Aug 29, 2017

If an "actionable" query string is present in the incoming URL, strip it to prevent duplication of object storage in case the delivery service's setting is to consider the qstring at the edge. If it is, leaving the qstring in place will potentially cause the same object to be stored twice; one object with the "actionable" TR query parameters and one without, if there are clients that make both types of requests.

Specific query strings are ?format=json, ?trred=false, and ?fakeClientIpAddress=foo.

Author: Jeff Elsloo
JIRA Link: https://issues.apache.org/jira/browse/TC-284
Found Version: 2.0.0

@limited limited added Improvement low impact affects only a small portion of a CDN, and cannot itself break one Traffic Router related to Traffic Router labels Aug 29, 2017
@rob05c rob05c added new feature A new feature, capability or behavior and removed improvement labels Jan 26, 2018
@zrhoffman zrhoffman added the tech debt rework due to choosing easy/limited solution label Apr 20, 2021
@rawlinp
Copy link
Contributor

rawlinp commented Jun 28, 2021

In general I think this would be good, but my worry is that there might be come clients/origins out there actually using a format query parameter. trred and fakeClientIpAddress seem less likely to be used by clients/origins since those are pretty TR-specific.

@ocket8888
Copy link
Contributor

#3554 would add an HTTP header for format so that you can do that instead of using the query string parameter, to help avoid that collision

@rawlinp
Copy link
Contributor

rawlinp commented Jun 29, 2021

Indeed, if only we could get all our clients to start passing a new header instead of the old query parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior tech debt rework due to choosing easy/limited solution Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants