Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cacheurl is deprecated in ATS 7.x #1130

Closed
smalenfant opened this issue Sep 6, 2017 · 8 comments
Closed

cacheurl is deprecated in ATS 7.x #1130

smalenfant opened this issue Sep 6, 2017 · 8 comments
Labels
documentation related to documentation Traffic Ops related to Traffic Ops
Milestone

Comments

@smalenfant
Copy link
Contributor

cacheurl is heavily used in the configuration generator for ATS. cacheurl has been deprecated in favor to cachekey in ATS 7.x.

There is currently no selection based on ATS version in ApacheTrafficServer.pm which makes it difficult to make those changes.

@dg4prez Can you take a look at this and tell me how we should implement this? For example here :

This is how we can replace cache_url ignore string with cachekey. How could we add the conditional based on ATS version targeted? Using the trafficserver/package/value?

                        #$text .= " \@plugin=cacheurl.so \@pparam=cacheurl_qstring.config";
                        $text .= " \@plugin=cachekey.so \@pparam=--remove-all-params=true";

This one above is easy, although how do we deal with all the other custom cacheurl_ parameters that gets added in the profiles? (Cache URL Expression in DS definition)

@smalenfant smalenfant added the Traffic Ops related to Traffic Ops label Sep 6, 2017
@dg4prez
Copy link
Contributor

dg4prez commented Sep 6, 2017 via email

@rob05c rob05c added the bug something isn't working as intended label Jan 26, 2018
@rob05c
Copy link
Member

rob05c commented Jan 29, 2018

Like @dg4prez said, we have cachekey working, and configurable. But it's not an automatic transition, and there's no documentation explaining how to do it.

I think we need documentation on how to migrate from cacheurl to cachekey before we can resolve this.

@rob05c rob05c added this to the 2.2.0 milestone Jan 29, 2018
@rob05c rob05c added documentation related to documentation and removed bug something isn't working as intended labels Jan 29, 2018
@ezelkow1
Copy link
Member

ezelkow1 commented Feb 6, 2018

This should be handled by #1602 and #1588

@rob05c
Copy link
Member

rob05c commented Feb 6, 2018

@ezelkow1 Is it all automatic, though? Or are there any config changes or parameters or anything that have to be set to use ATS 7, that need to be documented?

@ezelkow1
Copy link
Member

ezelkow1 commented Feb 6, 2018

Its not a completely automatic transition, users will have to convert their cacheurls to cachekeys if they want to move to ats7

Users will need to make parameters for a new cachekey.config with whatever settings they need for their key

@rob05c
Copy link
Member

rob05c commented Feb 6, 2018

Ok, we should probably put that under a heading for "Using ATS 6+", with a short paragraph explaining, in https://github.com/apache/incubator-trafficcontrol/blob/master/docs/source/admin/traffic_server.rst

@ezelkow1
Copy link
Member

ezelkow1 commented Feb 7, 2018

Added documentation in #1854

There may be other migration issues that can also be added there

@rob05c
Copy link
Member

rob05c commented Feb 12, 2018

TC now supports Cachekey, and documentation on migrating has been merged with #1854, therefore I'm resolving this. Any new Cachekey problems should be put in a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation related to documentation Traffic Ops related to Traffic Ops
Projects
None yet
Development

No branches or pull requests

4 participants