Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Ops needs to validate httpBypassFqdn for HTTP Delivery Services #2770

Closed
rawlinp opened this issue Aug 29, 2018 · 3 comments · Fixed by #6330
Closed

Traffic Ops needs to validate httpBypassFqdn for HTTP Delivery Services #2770

rawlinp opened this issue Aug 29, 2018 · 3 comments · Fixed by #6330
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Ops related to Traffic Ops
Milestone
6.0.1

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Aug 29, 2018

The old Perl UI validated that httpBypassFqdn is a valid hostname. Traffic Portal form validation was just fixed to do this as well in #2769, but we still need to perform Delivery Service API-level validation within traffic_ops_golang as well.
@rawlinp rawlinp added bug something isn't working as intended Traffic Ops API (golang) labels Aug 29, 2018
@rawlinp rawlinp mentioned this issue Aug 29, 2018
Closed
@mitchell852
Copy link
Member

what severity would you give this bug @rawlinp ? can you add the appropriate severity level?

@rawlinp rawlinp added the medium impact impacts a significant portion of a CDN, or has the potential to do so label Oct 17, 2018
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops and removed Traffic Ops related to Traffic Ops Traffic Ops API (golang) labels Oct 17, 2018
@mitchell852
Copy link
Member

this is still needed. reviewed in 8/17/21 working group.

@mitchell852 mitchell852 added the good first issue first-time committers will find this easy to resolve label Aug 17, 2021
@zrhoffman
Copy link
Member

zrhoffman commented Aug 17, 2021 •
edited
Loading

To be clear, Traffic Ops still needs this validation, Traffic Portal already validates httpBypassFqdn.

qtweng added a commit to qtweng/trafficcontrol that referenced this issue Nov 4, 2021
@qtweng
apache#2770: Add validation for httpBypassFqdn as hostname in Traffic…
6757a3f 
… Ops
@qtweng qtweng mentioned this issue Nov 4, 2021
Merged
4 tasks
rawlinp pushed a commit that referenced this issue Nov 4, 2021
@qtweng
#2770: Add validation for httpBypassFqdn as hostname in Traffic Ops (#…
44f2f44 
…6330)
@zrhoffman zrhoffman added this to the 6.0.1 milestone Nov 5, 2021
zrhoffman pushed a commit that referenced this issue Nov 5, 2021
@qtweng @zrhoffman
#2770: Add validation for httpBypassFqdn as hostname in Traffic Ops (#…
1d74141 
…6330)

(cherry picked from commit 44f2f44)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended good first issue first-time committers will find this easy to resolve medium impact impacts a significant portion of a CDN, or has the potential to do so Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
6.0.1
Development

Successfully merging a pull request may close this issue.

#2770: Add validation for httpBypassFqdn as hostname in Traffic Ops qtweng/trafficcontrol
3 participants
@mitchell852 @rawlinp @zrhoffman