Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the DNSSEC keys refresh API #3054

Closed
rawlinp opened this issue Nov 26, 2018 · 2 comments · Fixed by #6046
Closed

Improve the DNSSEC keys refresh API #3054

rawlinp opened this issue Nov 26, 2018 · 2 comments · Fixed by #6046
Labels
high impact impacts the basic function, deployment, or operation of a CDN new feature A new feature, capability or behavior Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes Traffic Ops related to Traffic Ops
Milestone
6.0.0

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Nov 26, 2018 •
edited

The current /api/1.4/cdns/dnsseckeys/refresh endpoint should be modified/enhanced:

  • Return a 202 Accepted to indicate that the request was received successfully but further processing is occurring in the background.
  • The 202 response should also include a link to a separate API endpoint that shows the current status of the refresh job that was kicked off (this means also implementing that separate API endpoint)
  • The refresh endpoint should also be changed to a PUT because mutation should not be done in a GET.
@rawlinp rawlinp added new feature A new feature, capability or behavior Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes labels Nov 26, 2018
@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Nov 18, 2019
@mitchell852 mitchell852 added the high impact impacts the basic function, deployment, or operation of a CDN label May 13, 2021
@mitchell852
Copy link
Member

Added the major label because GETs that write are dangerous imo.

@mitchell852 mitchell852 added this to the 6.0.0 milestone May 13, 2021
@rob05c
Copy link
Member

rob05c commented May 13, 2021

The refresh endpoint should also be changed to a POST because mutation should not be done in a GET.

Added the major label because GETs that write are dangerous imo.

It's not just extremely dangerous and deceptive, it's a violation of the HTTP spec.

@rawlinp rawlinp mentioned this issue Jul 20, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high impact impacts the basic function, deployment, or operation of a CDN new feature A new feature, capability or behavior Traffic Ops API Next Improvements to Traffic Ops API - particularly breaking changes Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Improve the DNSSEC refresh API rawlinp/trafficcontrol
3 participants
@mitchell852 @rob05c @rawlinp