Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the DNSSEC refresh API #6046

Merged
merged 2 commits into from Jul 21, 2021
Merged

Improve the DNSSEC refresh API #6046

merged 2 commits into from Jul 21, 2021

Conversation

rawlinp
Copy link
Contributor

@rawlinp rawlinp commented Jul 20, 2021

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client (Go)
  • Traffic Ops

What is the best way to verify this PR?

Ensure the added TO API test passes.
Build and view the DNSSEC refresh v4 API doc, make sure it renders properly without warnings.
PUT /api/4.0/cdns/dnsseckeys/refresh and verify that a Location response header is returned, and use the value to GET /async_status/{some_id} and verify the status message.

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@rawlinp rawlinp added new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops documentation related to documentation labels Jul 20, 2021
srijeet0406
srijeet0406 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good.
Unit/ API tests pass.
Manually hit the PUT api/4.0/cdns/dnsseckeys/refresh endpoint and got a 202 status code, with a link to GET the status from.
LGTM!

@zrhoffman zrhoffman merged commit 090bc90 into apache:master Jul 21, 2021
@rawlinp rawlinp deleted the improve-dnssec-refresh branch July 21, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srijeet0406 srijeet0406 srijeet0406 approved these changes

Assignees
No one assigned
Labels
documentation related to documentation new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the DNSSEC keys refresh API
3 participants
@rawlinp @srijeet0406 @zrhoffman