Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite /regions/{{region}}/phys_locations to Go #3812

Closed
1 task done
ocket8888 opened this issue Aug 6, 2019 · 2 comments · Fixed by #4336
Closed
1 task done

Rewrite /regions/{{region}}/phys_locations to Go #3812

ocket8888 opened this issue Aug 6, 2019 · 2 comments · Fixed by #4336
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Milestone
Go Rewrite

Comments

@ocket8888
Copy link
Contributor

ocket8888 commented Aug 6, 2019 •
edited

I'm submitting an ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Documentation (possibly)
  • Traffic Ops

Current behavior:

/regions/{{region}}/phys_locations is handled by Perl

Expected / new behavior:

/regions/{{region}}/phys_locations should be handled by Go.

Minimum API Version

1.1

Request Methods

  • POST

Minimal reproduction of the problem with instructions:

N/A
@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Aug 6, 2019
@ocket8888 ocket8888 added this to the Go Rewrite milestone Aug 13, 2019
@mitchell852
Copy link
Member

mitchell852 commented Sep 11, 2019 •
edited

i think this should be deprecated (not rewritten to Go and a deprecation notice added to the perl response) as you can simply POST /phys_locations

@rawlinp
Copy link
Contributor

rawlinp commented Sep 13, 2019

+1 on deprecation

@mhoppa mhoppa mentioned this issue Jan 27, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging a pull request may close this issue.

Deprecate /regions/:region_name/phys_locations mhoppa/trafficcontrol
3 participants
@mitchell852 @ocket8888 @rawlinp