Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite /riak/stats to Go #3859

Closed
1 task done
ocket8888 opened this issue Aug 7, 2019 · 3 comments · Fixed by #4349
Closed
1 task done

Rewrite /riak/stats to Go #3859

ocket8888 opened this issue Aug 7, 2019 · 3 comments · Fixed by #4349
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Milestone

Comments

@ocket8888
Copy link
Contributor

ocket8888 commented Aug 7, 2019

I'm submitting an ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Documentation (possibly)
  • Traffic Ops

Current behavior:

/riak/stats is handled by Perl

Expected / new behavior:

/riak/stats should be handled by Go.

Minimum API Version

1.1

Request Methods

  • GET

Minimal reproduction of the problem with instructions:

N/A

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Aug 7, 2019
@rawlinp
Copy link
Contributor

rawlinp commented Aug 7, 2019

This particular endpoint should be deprecated and not rewritten IMO. I believe this endpoint was primarily for informational/debug purposes during the initial integration of Riak and doesn't really provide much benefit to Traffic Control currently.

@ocket8888
Copy link
Contributor Author

I mean, that's fine by me but I think the general sentiment is we need to re-write all of /api/1.x before we can remove things.

@rawlinp
Copy link
Contributor

rawlinp commented Aug 7, 2019

I'm not saying to remove it, I'm saying it should be marked deprecated and not rewritten into Go. It will be removed when the rest of the Perl is removed.

@ocket8888 ocket8888 added this to the Go Rewrite milestone Aug 12, 2019
@mhoppa mhoppa mentioned this issue Jan 28, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants