Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Environment Variables override explicit configuration in client tests #3975

Open
ocket8888 opened this issue Oct 9, 2019 · 0 comments
Open

Environment Variables override explicit configuration in client tests #3975

ocket8888 opened this issue Oct 9, 2019 · 0 comments
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client Traffic Ops related to Traffic Ops

Comments

@ocket8888
Copy link
Contributor

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Control Client (Go) (integration tests with TO)

Current behavior:

If your TO_URL environment variable is set, it will override what's written in the tests' trafficOps.URL field in the configuration file.

Expected / new behavior:

Environmental factors should never override explicit configuration, makes it very difficult to tell why things aren't working.

Minimal reproduction of the problem with instructions:

TO_URL="https://google.com"

# ensure trafficOps.URL in the config file is set to something
# besides "https://google.com"
go test -v --cfg=path/to/traffic-ops-test.conf

# in the debug output you can see that it's attempting to connect
# to TO_URL not trafficOps.URL
@ocket8888 ocket8888 added bug something isn't working as intended tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client labels Oct 9, 2019
@mitchell852 mitchell852 added the Traffic Ops related to Traffic Ops label Nov 18, 2019
@ocket8888 ocket8888 added low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one labels Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something isn't working as intended low difficulty the estimated level of effort to resolve this issue is low low impact affects only a small portion of a CDN, and cannot itself break one tests related to tests and/or testing infrastructure TO Client (Go) related to the Go implementation of a TC client Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mitchell852 @ocket8888