Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unassigning all ONLINE ORG servers from an active, MSO-enabled DS #6069

Closed
rawlinp opened this issue Jul 29, 2021 · 0 comments · Fixed by #6077
Closed

Prevent unassigning all ONLINE ORG servers from an active, MSO-enabled DS #6069

rawlinp opened this issue Jul 29, 2021 · 0 comments · Fixed by #6077
Assignees
@rawlinp
Labels
improvement The functionality exists but it could be improved in some way. multi-site origin Related to the Multi-Site Origin feature Traffic Ops related to Traffic Ops
Milestone
6.0.0

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Jul 29, 2021 •
edited
Loading

I'm submitting a ...

  • improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

You can unassign all ONLINE ORG servers from an active, MSO-enabled delivery service. Doing this causes the ATS config generation to use the DS's orgServerFqdn field for parentage instead of the assigned ORG servers, which is incorrect (and very bad).

New behavior:

TO should prevent this from happening. If you really intend to remove all ONLINE ORG servers from an MSO-enabled delivery service, you should have to deactivate it first or disable MSO.

Minimal reproduction of the problem with instructions:

For an MSO-enabled delivery service, unassign all of its ONLINE ORG servers.
@rawlinp rawlinp added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. labels Jul 29, 2021
@rawlinp rawlinp added this to the 6.0.0 milestone Jul 29, 2021
@rawlinp rawlinp self-assigned this Jul 30, 2021
rawlinp added a commit to rawlinp/trafficcontrol that referenced this issue Jul 30, 2021
@rawlinp
Prevent unassigning all ONLINE ORG servers from active MSO-enabled DS
a05fe85 
Also, fix some cases where it was possible to delete/unassign all
`EDGE`-type servers from a delivery service if there were also
`ORG`-type servers assigned.

Closes: apache#6069
Closes: apache#5212
@rawlinp rawlinp mentioned this issue Jul 30, 2021
Merged
5 tasks
zrhoffman pushed a commit that referenced this issue Aug 3, 2021
@rawlinp
Prevent unassigning all ONLINE ORG servers from an active, MSO-enable…
64ed7f9 
…d DS (#6077)

* Prevent unassigning all ONLINE ORG servers from active MSO-enabled DS

Also, fix some cases where it was possible to delete/unassign all
`EDGE`-type servers from a delivery service if there were also
`ORG`-type servers assigned.

Closes: #6069
Closes: #5212

* Fix v2 and v3 TO API integration tests

* Address review comments

Simplify queries, remove double-space in alert message, and change if to
else-if.
@zrhoffman zrhoffman added the multi-site origin Related to the Multi-Site Origin feature label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rawlinp rawlinp

Labels
improvement The functionality exists but it could be improved in some way. multi-site origin Related to the Multi-Site Origin feature Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Prevent unassigning all ONLINE ORG servers from an active, MSO-enabled DS rawlinp/trafficcontrol
2 participants
@rawlinp @zrhoffman