Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed maxLength of zip code to be longer. #1792

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Conversation

dneuman64
Copy link
Contributor

I removed the zip code length restriction in the TO UI and Changed it to be 11 in traffic portal. This should allow for Zip codes of other countries to be used as well as US zip codes with extensions.

This closes #1761

@dneuman64 dneuman64 added Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1 labels Jan 24, 2018
@asfgit
Copy link
Contributor

asfgit commented Jan 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/929/
Test FAILed.

@limited
Copy link
Contributor

limited commented Jan 24, 2018

I think we need to allow letters too. Canadians use the alphabet in their postal codes:
https://en.wikipedia.org/wiki/Postal_codes_in_Canada#Components_of_a_postal_code

@dneuman64
Copy link
Contributor Author

Good point, I can make that change.

@dneuman64
Copy link
Contributor Author

OK @limited I removed the check completely since all that was left was [0-9].

@dneuman64 dneuman64 added this to the 2.2.0 milestone Jan 24, 2018
@limited limited merged commit 3c11b3d into apache:master Jan 24, 2018
@asfgit
Copy link
Contributor

asfgit commented Jan 24, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/930/
Test PASSed.

@RSK14
Copy link

RSK14 commented Jan 25, 2018

Thank you so much Dave and team i will check and let you know

Thanks,
Satheesh R

@RSK14
Copy link

RSK14 commented Jan 25, 2018

ya now i can enter 6 digit zip code in ops 2.2 version but i can't update 2.1 version (5 digit only accept.)

Thank you so much for fixed this issue.

what is the difference 2.1 and 2.2?

Thanks
Satheesh R

@limited
Copy link
Contributor

limited commented Jan 25, 2018

The change was only committed to the master branch (which will become 2.2).

2.1 released last week and doesn't contain this enhancement.

@RSK14
Copy link

RSK14 commented Jan 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Traffic Ops related to Traffic Ops Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic OPS ZIPCode
4 participants