prevents parent.config failure when no delivery services assinged #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
dangogh
reviewed
Feb 21, 2018
|
|
||
| if ( $ds->{qstring_ignore} == 0 && !defined($ds_qsh) ) { | ||
| $parent_qstring = "consider"; | ||
| unless (!defined($data->{dslist})) { |
There was a problem hiding this comment.
umm... unless (!...) is much more easily written as if (...)
There was a problem hiding this comment.
Can't really argue with that. Updated.
dg4prez
force-pushed
the
no_services_assigned
branch
from
aa843c7
to
b10567f
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that there are delivery services assigned before trying to process them.