Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To go deletednsseckeys #2369

Merged
merged 1 commit into from Jul 12, 2018
Merged

To go deletednsseckeys #2369

merged 1 commit into from Jul 12, 2018

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Jun 4, 2018

Branched from #2365 - recommend merging that first.

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 4, 2018
@rob05c rob05c mentioned this pull request Jun 4, 2018
Closed
@asfgit
Copy link
Contributor

asfgit commented Jun 4, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1758/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1775/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 8, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1787/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1801/
Test PASSed.

@rob05c rob05c force-pushed the to-go-deletednsseckeys branch 2 times, most recently from b770644 to f247c3a Compare June 19, 2018 21:44
@asfgit
Copy link
Contributor

asfgit commented Jun 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1852/
Test PASSed.

@rob05c rob05c force-pushed the to-go-deletednsseckeys branch 2 times, most recently from 03752ab to 2476da0 Compare July 2, 2018 16:47
@asfgit
Copy link
Contributor

asfgit commented Jul 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1961/
Test FAILed.

@asfgit
Copy link
Contributor

asfgit commented Jul 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1963/
Test PASSed.

alficles
alficles suggested changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@alficles alficles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned we may be leaking something here. Can you check on it?

traffic_ops/traffic_ops_golang/cdn/dnssec.go
api.HandleErr(w, r, http.StatusInternalServerError, nil, errors.New("getting riak cluster: "+err.Error()))
return
}
if err := riakCluster.Start(); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see this paired with a .Stop() somewhere. Is it missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@asfgit
Copy link
Contributor

asfgit commented Jul 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1969/
Test PASSed.

alficles
alficles approved these changes Jul 5, 2018
View reviewed changes
Copy link
Contributor

@alficles alficles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this is good to merge now.

@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2012/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2051/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2065/
Test PASSed.

@mitchell852 mitchell852 merged commit 78222fe into apache:master Jul 12, 2018
@rob05c rob05c deleted the to-go-deletednsseckeys branch January 2, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alficles alficles alficles approved these changes

Assignees
No one assigned
Labels
new feature A new feature, capability or behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rob05c @asfgit @alficles @mitchell852