Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To go cdns sslkeys #2400

Merged
merged 1 commit into from Jul 11, 2018
Merged

To go cdns sslkeys #2400

merged 1 commit into from Jul 11, 2018

Conversation

rob05c
Copy link
Member

@rob05c rob05c commented Jun 12, 2018

Branched from #2365 - recommend merging that first.

@rob05c rob05c added new feature A new feature, capability or behavior Traffic Ops API (golang) labels Jun 12, 2018
@rob05c rob05c mentioned this pull request Jun 12, 2018
Closed
@asfgit
Copy link
Contributor

asfgit commented Jun 12, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1795/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 13, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1808/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jun 20, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR/1850/
Test PASSed.

alficles
alficles approved these changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@alficles alficles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might could use some improvement, but it appears to do what the Perl did, for better or for worse. I suggest merging and then reconsidering the things noted in the TODOs.

@asfgit
Copy link
Contributor

asfgit commented Jul 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1964/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 5, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2014/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 9, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2048/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2063/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 10, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2074/
Test PASSed.

mitchell852
mitchell852 reviewed Jul 11, 2018
View reviewed changes
traffic_ops/traffic_ops_golang/routes.go Outdated
@@ -108,6 +108,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, http.Handler, error) {
{1.1, http.MethodPost, `cachegroups/{id}/queue_update$`, cachegroup.QueueUpdates(d.DB.DB), auth.PrivLevelOperations, Authenticated, nil},

//CDN
{1.1, http.MethodGet, `cdns/name/{name}/sslkeys/?(\.json)?$`, cdn.GetSSLKeys, auth.PrivLevelOperations, Authenticated, nil},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is supposed to be admin priv level

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mitchell852 Fixed

@asfgit
Copy link
Contributor

asfgit commented Jul 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2081/
Test PASSed.

@asfgit
Copy link
Contributor

asfgit commented Jul 11, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2082/
Test PASSed.

@mitchell852 mitchell852 merged commit 31b9b97 into apache:master Jul 11, 2018
@rob05c rob05c deleted the to-go-cdns-sslkeys branch January 2, 2019 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchell852 mitchell852 mitchell852 left review comments

@alficles alficles alficles approved these changes

Assignees
No one assigned
Labels
new feature A new feature, capability or behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rob05c @asfgit @mitchell852 @alficles