Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require golang-1.9.4 using yum for all go components #2473

Merged
merged 1 commit into from Jun 27, 2018
Merged

require golang-1.9.4 using yum for all go components #2473

merged 1 commit into from Jun 27, 2018

Conversation

dangogh
Copy link
Member

@dangogh dangogh commented Jun 26, 2018

to get some consistency in the version of Go used in all components, install golang-1.9.4 package from yum when building. Also requires golang-1.9.4 when installing the traffic_ops rpm, since postinstall also uses the go compiler (for goose).

@asfgit
Copy link
Contributor

asfgit commented Jun 26, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/1916/
Test PASSed.

@dewrich
Copy link
Contributor

dewrich commented Jun 26, 2018

@dangogh and the Jenkins build flow still works? ie: the pkg command

@dangogh
Copy link
Member Author

dangogh commented Jun 26, 2018

@dewrich -- yes -- click on the Details link under the "All checks have passed" comment from jenkins to get to the results

@dewrich dewrich merged commit 3eed871 into apache:master Jun 27, 2018
@dangogh dangogh deleted the go-1.9.4 branch September 17, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants