Removed restangular from CDNService #3602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
force-pushed
the
removing-restangular-CDNService
branch
from
2131322
to
75f1766
Compare
dangogh
added
tech debt
ocket8888
force-pushed
the
removing-restangular-CDNService
branch
from
75f1766
to
f5b5354
Compare
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
force-pushed
the
removing-restangular-CDNService
branch
from
f5b5354
to
c357567
Compare
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
force-pushed
the
removing-restangular-CDNService
branch
from
c357567
to
9db05dd
Compare
|
Refer to this link for build results (access rights to CI server needed): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
Removes a dependency on Restangular from the "CDNService"
Which Traffic Control components are affected by this PR?
Traffic Portal dependencies are not individually documented, and so no documentation changes are necessary.
What is the best way to verify this PR?
No functionality should have changed (except that errors will now be logged instead of ignored in many cases), so the existing tests should all pass.
Jeremy: actually, the only way to truly verify that the functionality did not change is to:
The following criteria are ALL met by this PR