Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite /cachegroups/{id}/unassigned_parameters to golang #3905

Merged

Conversation

mhoppa
Copy link
Contributor

@mhoppa mhoppa commented Sep 5, 2019

What does this PR (Pull Request) do?

This PR rewrites the /cachegroups/{id}/unassigned_parameters endpoint to Go

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Bring up TO locally and hit the endpoint to ensure parity between perl implementation and newly written Golang implementation

The API tests and/or unit tests for TO can be run to verify the PR.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@asf-ci
Copy link
Contributor

asf-ci commented Sep 5, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4206/
Test PASSed.

@ocket8888 ocket8888 added tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops labels Sep 6, 2019
@ocket8888 ocket8888 added this to the Go Rewrite milestone Sep 6, 2019
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs fine, manual testing confirms it works, automated unit and client tests make sense and pass

@ocket8888 ocket8888 merged commit 968cb6c into apache:master Sep 9, 2019
@mhoppa mhoppa deleted the feature/rewrite_cg_unassigned_parameters branch September 9, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite /cachegroups/{{id}}/unassigned_parameters to Go
3 participants