Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote /dbdump to Go #3912

Merged
merged 6 commits into from Sep 24, 2019
Merged

Rewrote /dbdump to Go #3912

merged 6 commits into from Sep 24, 2019

Conversation

ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client
  • Traffic Ops

What is the best way to verify this PR?

Call the endpoint and use the response data as the input to pg_restore - verify the resulting database is identical to the one dumped at the time it was dumped. I don't know how that could be tested as a unit test, so I didn't write one. I also think it's generally inadvisable to use this endpoint, as a full dump of what is essentially an implementation detail of the API through the API itself seems like an un-document-able nightmare. I'd advise system engineers in need of recreating and/or backing up the database do so by directly using the pg_dump tool, rather than the TO API.

The following criteria are ALL met by this PR

  • I have explained why tests are unnecessary
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@asf-ci
Copy link
Contributor

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4217/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 9, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4220/
Test FAILed.

@ocket8888 ocket8888 force-pushed the dbdump-go branch 2 times, most recently from b4036c1 to 903d967 Compare September 10, 2019 14:36
@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4222/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4223/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4224/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4225/
Test PASSed.

@ocket8888 ocket8888 force-pushed the dbdump-go branch 2 times, most recently from 261d309 to 9ce28e3 Compare September 10, 2019 18:32
@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4226/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4227/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4228/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4229/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4230/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4231/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4232/
Test PASSed.

@ocket8888 ocket8888 force-pushed the dbdump-go branch 2 times, most recently from d9beb1e to f6d9b08 Compare September 10, 2019 21:56
@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4233/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4234/
Test PASSed.

@ocket8888 ocket8888 marked this pull request as ready for review September 10, 2019 22:18
@asf-ci
Copy link
Contributor

asf-ci commented Sep 10, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4235/
Test FAILed.

@ocket8888 ocket8888 added cdn-in-a-box related to the Docker-based CDN-in-a-Box system documentation related to documentation tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops labels Sep 11, 2019
@ocket8888 ocket8888 added this to the Go Rewrite milestone Sep 11, 2019
@ocket8888 ocket8888 added the tech debt rework due to choosing easy/limited solution label Sep 11, 2019
@asf-ci
Copy link
Contributor

asf-ci commented Sep 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4247/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 13, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4249/
Test PASSed.

mhoppa
mhoppa approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

infrastructure/cdn-in-a-box/traffic_ops_integration_test/Dockerfile Show resolved Hide resolved
mitchell852
mitchell852 approved these changes Sep 24, 2019
View reviewed changes
Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

@mitchell852 mitchell852 merged commit fab1f00 into apache:master Sep 24, 2019
@ocket8888 ocket8888 deleted the dbdump-go branch September 24, 2019 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp rawlinp left review comments

@mitchell852 mitchell852 mitchell852 approved these changes

@mhoppa mhoppa mhoppa approved these changes

Assignees
No one assigned
Labels
cdn-in-a-box related to the Docker-based CDN-in-a-Box system documentation related to documentation tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging this pull request may close these issues.

Rewrite /dbdump to Go
5 participants
@ocket8888 @asf-ci @mitchell852 @rawlinp @mhoppa