Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SMTP configuration and APIInfo Email method #3925

Merged
merged 7 commits into from Oct 8, 2019

Conversation

ocket8888
Copy link
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Ops

The configuration file is undocumented. It shouldn't be, but doing so is outside the scope of this PR.

What is the best way to verify this PR?

Create a configuration file with a valid SMTP server configuration and try to start Traffic Ops. Config should parse fine.

The following criteria are ALL met by this PR

  • Tests are unnecessary
  • I have explained why documentation is absent
  • This PR includes an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

@asf-ci
Copy link
Contributor

asf-ci commented Sep 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4263/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4265/
Test FAILed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 17, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4267/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 19, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4286/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 19, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4288/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 19, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4290/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4299/
Test PASSed.

@asf-ci
Copy link
Contributor

asf-ci commented Sep 23, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4300/
Test FAILed.

Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does https://traffic-control-cdn.readthedocs.io/en/latest/admin/traffic_ops/configuration.html need to be updated to include the new configuration option?

traffic_ops/traffic_ops_golang/config/config.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/api/api.go Outdated Show resolved Hide resolved
traffic_ops/traffic_ops_golang/api/api.go Show resolved Hide resolved
traffic_ops/traffic_ops_golang/config/config.go Outdated Show resolved Hide resolved
@asf-ci
Copy link
Contributor

asf-ci commented Oct 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4406/

@asf-ci
Copy link
Contributor

asf-ci commented Oct 7, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4410/

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops new feature A new feature, capability or behavior configuration related to configuration - not limited to any one component labels Oct 8, 2019
@mitchell852 mitchell852 merged commit baef562 into apache:master Oct 8, 2019
@ocket8888 ocket8888 deleted the smtp branch October 8, 2019 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration related to configuration - not limited to any one component new feature A new feature, capability or behavior Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants