TP: Ability to manage capabilities of servers #3998

mitchell852 · 2019-10-16T17:09:02Z

What does this PR (Pull Request) do?

This PR provides users with the ability to:

assign/remove server capabilities to/from a server
view all servers that have a specific capability and, if needed, remove a server from a capability.
This PR is not related to any Issue but is related to this blueprint

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?

Launch TP
ensure that server capabilities exist: tp.domain.com/#!/server-capabilities (if not, add one or two)
navigate to any server: tp.domain.com/#!/servers/{id}
click on More > Manage Capabilities
add/remove capabilities to/from the server but leave at least one capability on the server.
navigate back to a capability you left on the server - tp.domain.com/#!/server-capabilities/{capability name}
click 'view servers' to see the servers that utilize the capability and remove a server from the capability.

The following criteria are ALL met by this PR

This PR includes tests OR I have explained why tests are unnecessary
This PR includes documentation OR I have explained why documentation is unnecessary
This PR includes an update to CHANGELOG.md OR such an update is not necessary
This PR includes any and all required license headers
This PR ensures that database migration sequence is correct OR this PR does not include a database migration
This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

Capabilities assigned to a server:

Servers that utilize a capability:

asf-ci · 2019-10-16T17:14:57Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4550/

asf-ci · 2019-10-16T18:33:54Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4554/

asf-ci · 2019-10-16T18:35:21Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4556/

asf-ci · 2019-10-16T20:17:08Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4559/

asf-ci · 2019-10-16T20:23:52Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4560/

asf-ci · 2019-10-17T15:11:25Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4565/

traffic_portal/app/src/common/modules/dialog/select/DialogSelectController.js

traffic_portal/app/src/common/modules/form/serverCapability/form.serverCapability.tpl.html

.../app/src/common/modules/table/serverCapabilityServers/table.serverCapabilityServers.tpl.html

...src/common/modules/table/serverServerCapabilities/TableServerServerCapabilitiesController.js

...pp/src/common/modules/table/serverServerCapabilities/table.serverServerCapabilities.tpl.html

asf-ci · 2019-10-22T17:37:36Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4604/

asf-ci · 2019-10-22T18:11:47Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4605/

asf-ci · 2019-10-22T19:55:19Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4609/

asf-ci · 2019-10-22T20:20:17Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4611/

…bility

…apabilities and also made verbiage consistent

…table) and navigate to the server capability

asf-ci · 2019-10-22T20:54:12Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4612/

asf-ci · 2019-10-23T21:28:49Z

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4629/

ocket8888

Verified manually that it works, tests pass, docs build without error and are accurate and properly formatted, No _.js dependency

mitchell852 added new feature A new feature, capability or behavior Traffic Portal v1 related to Traffic Portal version 1 labels Oct 16, 2019

mitchell852 force-pushed the s-s-caps-ui branch 2 times, most recently from 470faaa to a828298 Compare October 16, 2019 18:03

ocket8888 requested changes Oct 17, 2019

View reviewed changes

mitchell852 force-pushed the s-s-caps-ui branch from 5f02cbf to 6eca61a Compare October 22, 2019 17:28

mitchell852 force-pushed the s-s-caps-ui branch 2 times, most recently from fa79a4c to 49474dd Compare October 22, 2019 18:05

mitchell852 marked this pull request as ready for review October 22, 2019 20:23

mitchell852 added 11 commits October 22, 2019 14:24

adds server capbility management to a server

5d61883

adds the ability to view the servers that are utilizing a server capa…

9fe8f62

…bility

removes unecessary click handler

44b61f9

sends query params correctly

eabf1e3

fixes styling on table row and changes hover verbiage

137b08f

adds context menu item to the servers table for managing a server's c…

aae97c2

…apabilities and also made verbiage consistent

adds the ability to click on a server capability of a server (in the …

ea21b7b

…table) and navigate to the server capability

adds UI tests for server to server capability assignment

bace315

changes per PR review

ededa92

adds a simplified context menu to the server capability servers table

3939869

adds the ability to quickly remove the server from the capability

8c2e3e7

mitchell852 added 2 commits October 22, 2019 14:24

adds docs for assigning a server capability to a server

d2420eb

adds changelog entry for associating capabilities with servers.

93f5fe4

mitchell852 force-pushed the s-s-caps-ui branch from 1a3997a to 93f5fe4 Compare October 22, 2019 20:25

fixes bug with UI message not showing on success

085a9ba

ocket8888 approved these changes Oct 24, 2019

View reviewed changes

ocket8888 merged commit 1df7511 into apache:master Oct 24, 2019

mitchell852 changed the title ~~TP: Ability to manager capabilities of servers~~ TP: Ability to manage capabilities of servers Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TP: Ability to manage capabilities of servers #3998

TP: Ability to manage capabilities of servers #3998

mitchell852 commented Oct 16, 2019 •

edited

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 17, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 23, 2019

ocket8888 left a comment

TP: Ability to manage capabilities of servers #3998

TP: Ability to manage capabilities of servers #3998

Conversation

mitchell852 commented Oct 16, 2019 • edited

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

What is the best way to verify this PR?

The following criteria are ALL met by this PR

Additional Information

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 16, 2019

asf-ci commented Oct 17, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 22, 2019

asf-ci commented Oct 23, 2019

ocket8888 left a comment

Choose a reason for hiding this comment

mitchell852 commented Oct 16, 2019 •

edited