Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: fixes bug that surfaces when trying to compare profiles without params #4008

Merged

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Oct 22, 2019

What does this PR (Pull Request) do?

This PR fixes a bug highlighted by a failing UI test. When comparing 2 profiles, if one or both of the profiles has no params, then the comparison page fails to load.

  • This PR is not related to any Issue

  • No tests as this is a scenario covered by a current UI test

  • No documentation as this is simply a bug fix

  • No changelog.md entry as this bug was not released with any TC release

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • In TP, navigate to the profiles view - tp.domain.com/#!/profiles
  • Select 2 profiles to compare. Ensure that at least one of those profiles has ZERO params associated with it
  • Ensure that the profile diff page is displayed correctly.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1 labels Oct 22, 2019
@asf-ci
Copy link
Contributor

asf-ci commented Oct 22, 2019

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4600/

Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, tests pass, no _.js.

@ocket8888 ocket8888 merged commit 0d153c6 into apache:master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants