Block server servercapability delete if associated ds requires it #4041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
requested changes
Oct 29, 2019
traffic_ops/traffic_ops_golang/server/servers_server_capability.go
Outdated
Show resolved
Hide resolved
|
Refer to this link for build results (access rights to CI server needed): |
ocket8888
added
bug
|
Refer to this link for build results (access rights to CI server needed): |
|
what about the opposite scenario? blocking ds required capability addition IF assigned servers don't have that capability. i suppose that doesn't belong in this PR but just thought i'd bring it up. |
ocket8888
approved these changes
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR adds in extra validation in disassociating a server capability from a server. If that server is assigned to a DS that requires that server capability we now block the DELETE.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Besides running API tests it can be manually tested by:
If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR
Additional Information