Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate /deliveryservice_user/:dsId/:userId #4367

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

mhoppa
Copy link
Contributor

@mhoppa mhoppa commented Jan 31, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Ops

What is the best way to verify this PR?

Make request to /deliveryservice_user/:dsId/:userId and ensure deprecation notice is returned and then build docs and make sure they render correctly with deprecation notice on it.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@ocket8888 ocket8888 added documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops labels Jan 31, 2020
@ocket8888 ocket8888 added this to the Go Rewrite milestone Jan 31, 2020
@ocket8888 ocket8888 self-assigned this Jan 31, 2020
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed deprecation notices in responses to manual requests, docs look good and compile without errors/warnings.

@ocket8888 ocket8888 merged commit 33ce532 into apache:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation related to documentation tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Rewrite /deliveryservice_user/{{DSID}}/{{userID}} to Go
2 participants