Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dnssec refresh endpoint #4386

Merged
merged 1 commit into from Feb 20, 2020
Merged

Fix dnssec refresh endpoint #4386

merged 1 commit into from Feb 20, 2020

Conversation

mhoppa
Copy link
Contributor

@mhoppa mhoppa commented Feb 7, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Have TO up in an environment with access to available riak and CDNs with dnssec enabled.
Make a request to the GET /cdns/dnsseckeys/refresh and then look at the TO logs and make sure it correctly checked all the CDNs keys correctly. Better test would be of course if one of the CDN dnssec keys was expired on the CDN and after hitting the route making sure the key was refreshed.

There is no tests for this as our API tests do not have access to riak.

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mhoppa mhoppa changed the title Fix dnssec refresh endpoint WIP - Fix dnssec refresh endpoint Feb 7, 2020
@mhoppa
Copy link
Contributor Author

mhoppa commented Feb 7, 2020 •
edited

want to check with expired keys prior to marking this ready to go so WIP atm

@rawlinp rawlinp added bug something isn't working as intended regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) labels Feb 7, 2020
@rawlinp rawlinp added this to the Go Rewrite milestone Feb 7, 2020
@ocket8888 ocket8888 self-assigned this Feb 10, 2020
@mhoppa mhoppa changed the title WIP - Fix dnssec refresh endpoint Fix dnssec refresh endpoint Feb 13, 2020
@mhoppa
Copy link
Contributor Author

mhoppa commented Feb 13, 2020

ready for review please remove the WIP tag

@ocket8888 ocket8888 removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Feb 13, 2020
rawlinp
rawlinp approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@rawlinp rawlinp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rawlinp rawlinp merged commit 07d750d into apache:master Feb 20, 2020
@mitchell852 mitchell852 removed the bug something isn't working as intended label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlinp rawlinp rawlinp approved these changes

Assignees

@ocket8888 ocket8888

Labels
regression bug a bug in existing functionality introduced by a new version Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
Go Rewrite
Development

Successfully merging this pull request may close these issues.

Bug in /cdns/dnsseckeys/refresh
4 participants
@mhoppa @rawlinp @mitchell852 @ocket8888