Fixed /api/2.0/roles always returning empty array #4397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
bug
|
Not really sure about "medium", but at best it means that new users can not be created and old ones can't be updated - which is a bit of a big deal when users can't be deleted. |
mhoppa
suggested changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
The
/rolesendpoint when called in API version 2.0 is always returning an empty array because of how it handles the new v1.3 fields. This fixes that.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Build and run, make a GET request to
/roles, verify the resulting array of roles is not empty.If this is a bug fix, what versions of Traffic Control are affected?
The following criteria are ALL met by this PR