Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: Fixes missing ecs enabled property on a number of ds tables #4400

Merged
merged 2 commits into from Feb 18, 2020

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Feb 13, 2020

What does this PR (Pull Request) do?

The newly added ECS Enabled field was not added to a handful of ds tables which caused each table to fail to render.

no documentation changes needed for this regression.
existing UI tests do not cover tables at the column level.
no change log entry required.

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Run the UI tests

  2. Navigate to each table and ensure it renders properly and you can show/hide table columns.

https://tp.example.com/#!/cdns/1/delivery-services
https://tp.example.com/#!/profiles/458/delivery-services (must be a profile of type=DS_PROFILE)
https://tp.example.com/#!/servers/1036/delivery-services (must be a server of type=EDGE)
https://tp.example.com/#!/tenants/4/delivery-services
https://tp.example.com/#!/types/9/delivery-services (must be a type where useintable=deliveryservice)
https://tp.example.com/#!/users/597/delivery-services

If this is a bug fix, what versions of Traffic Control are affected?

  • master

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal related to Traffic Portal bug something isn't working as intended regression bug a bug in existing functionality introduced by a new version labels Feb 13, 2020
@mitchell852 mitchell852 marked this pull request as ready for review February 13, 2020 21:28
@mitchell852 mitchell852 changed the title TP: Fixes missubg ecs enabled property on a number of ds tables TP: Fixes missing ecs enabled property on a number of ds tables Feb 13, 2020
@mitchell852
Copy link
Member Author

@mattjackson220 is going to review this.

@mitchell852 mitchell852 added the high impact impacts the basic function, deployment, or operation of a CDN label Feb 18, 2020
@mattjackson220
Copy link
Contributor

This is great! tested locally and all tables successfully add the new option!

@rawlinp rawlinp merged commit 89ab66e into apache:master Feb 18, 2020
@mitchell852 mitchell852 removed the bug something isn't working as intended label Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high impact impacts the basic function, deployment, or operation of a CDN regression bug a bug in existing functionality introduced by a new version Traffic Portal related to Traffic Portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TP delivery service tables fail to render due to missing ds property (ECS Enabled)
3 participants