Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TP: upgrades application build dependencies #4401

Merged
merged 2 commits into from Mar 2, 2020

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Feb 13, 2020

What does this PR (Pull Request) do?

Upgrades TP's application dependencies. No documentation updates required and current UI tests are sufficient to ensure no regressions.

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  1. Start up cdn in a box which will build and package TP into an RPM. This RPM will then be installed and the Traffic Portal service will be started. Ensure TP runs without errors.

  2. Run the UI tests pointed at TP in cdn in a box to ensure any existing functionality was not broken.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal related to Traffic Portal tech debt rework due to choosing easy/limited solution labels Feb 13, 2020
@mitchell852 mitchell852 marked this pull request as ready for review February 13, 2020 22:43
@mitchell852 mitchell852 added the build related to the build process label Feb 13, 2020
@mitchell852 mitchell852 changed the title TP: upgrades load-grunt-config to 3.0.1 and removes grun-usemin TP: upgrades/removes application build dependencies Feb 13, 2020
@mitchell852 mitchell852 changed the title TP: upgrades/removes application build dependencies TP: upgrades application build dependencies Feb 13, 2020
@ocket8888
Copy link
Contributor

Why upgrade that one, specifically? Most of our dependencies are pretty out-of-date

@mitchell852
Copy link
Member Author

Why upgrade that one, specifically? Most of our dependencies are pretty out-of-date

hold off and i'll see what other deps can / should be upgraded.

@mitchell852 mitchell852 added the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Feb 14, 2020
@mitchell852 mitchell852 force-pushed the removes-npm-packages-with-vuln branch 4 times, most recently from 974a21b to 3e9737b Compare February 27, 2020 21:29
@mitchell852 mitchell852 removed the WIP "Work-in-Progress" - do not merge! (use 'draft' pull requests from now on) label Feb 27, 2020
Copy link
Contributor

@mhoppa mhoppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually testing looks good, TP automated tests run successful.

@ocket8888 ocket8888 merged commit 78b261d into apache:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build related to the build process tech debt rework due to choosing easy/limited solution Traffic Portal related to Traffic Portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants