Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DS SSL keys not updating when updating CDN #4988

Merged
merged 4 commits into from
Sep 18, 2020
Merged

Fix DS SSL keys not updating when updating CDN #4988

merged 4 commits into from
Sep 18, 2020

Conversation

shamrickus
Copy link
Member

@shamrickus shamrickus commented Aug 25, 2020

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Control Client (Go)
  • Traffic Ops

What is the best way to verify this PR?

Given two CDNs x1 and x2:

  • Create a DS y on CDN x1
  • Generate SSL keys for y
  • Update y to be on CDN x2
  • Verify SSL keys are now on x2 and not x1

Run the api tests and verify that they pass. Note: the ssl keys test are marked as a system test as they need riak to work.

If this is a bug fix, what versions of Traffic Control are affected?

master (55b3b03)

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR ensures that database migration sequence is correct OR this PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops bug something isn't working as intended labels Aug 26, 2020
@mitchell852
Copy link
Member

mitchell852 commented Aug 26, 2020

@shamrickus - is this related or a fix to #1847 ? If so, can you update the PR description and probably create a changelog entry noting that this was fixed.

@shamrickus
Copy link
Member Author

Yes

@mitchell852
Copy link
Member

@shamrickus - can you fix the conflict?

@shamrickus
Copy link
Member Author

Done

@mitchell852
Copy link
Member

Run the api tests and verify that they pass

Not sure you have to mention that anymore due to our nifty GHA that runs the API tests :)

Copy link
Member

@mitchell852 mitchell852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing sync between Riak and Traffic-Ops on DS CDN change
2 participants