-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TP Tests GHA #5351
Merged
Merged
Add TP Tests GHA #5351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchell852
added
Traffic Portal v1
related to Traffic Portal version 1
tests
related to tests and/or testing infrastructure
automation
related to automated testing/deployment/packaging etc.
labels
Dec 8, 2020
Looks like this is ready for review.
Would you please rebase so that your commits follow the minimum number of logical steps to make the result of what you did? |
It has been reduced to 14 commits. |
zrhoffman
requested changes
Dec 10, 2020
tcfdev
reviewed
Dec 11, 2020
tcfdev
reviewed
Dec 11, 2020
tcfdev
reviewed
Dec 11, 2020
zrhoffman
reviewed
Dec 23, 2020
zrhoffman
requested changes
Dec 23, 2020
looks like all feedback has been addressed. merging. |
zrhoffman
reviewed
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automation
related to automated testing/deployment/packaging etc.
tests
related to tests and/or testing infrastructure
Traffic Portal v1
related to Traffic Portal version 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR (Pull Request) do?
This PR adds a Github Action for TP e2e tests. It also modifies some TP tests
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run TP test locally and verify they still pass
Ensure changing a TP file triggers the GHA, and the GHA passes (by making a fork of this PR)
The following criteria are ALL met by this PR
Additional Information