Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TP Tests GHA #5351

Merged
merged 20 commits into from
Dec 29, 2020
Merged

Add TP Tests GHA #5351

merged 20 commits into from
Dec 29, 2020

Conversation

shamrickus
Copy link
Member

@shamrickus shamrickus commented Dec 4, 2020

What does this PR (Pull Request) do?

This PR adds a Github Action for TP e2e tests. It also modifies some TP tests

Which Traffic Control components are affected by this PR?

  • Traffic Portal
  • CI tests

What is the best way to verify this PR?

Run TP test locally and verify they still pass
Ensure changing a TP file triggers the GHA, and the GHA passes (by making a fork of this PR)

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@shamrickus shamrickus marked this pull request as ready for review December 7, 2020 21:12
@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 tests related to tests and/or testing infrastructure automation related to automated testing/deployment/packaging etc. labels Dec 8, 2020
@zrhoffman
Copy link
Member

zrhoffman commented Dec 8, 2020

Looks like this is ready for review.

Commits 90

Would you please rebase so that your commits follow the minimum number of logical steps to make the result of what you did?

@shamrickus
Copy link
Member Author

It has been reduced to 14 commits.

.github/actions/tp-e2e-tests/entrypoint.sh Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/cdn.json Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
.github/actions/tp-e2e-tests/entrypoint.sh Outdated Show resolved Hide resolved
@mitchell852
Copy link
Member

looks like all feedback has been addressed. merging.

@mitchell852 mitchell852 merged commit c2ad1ff into apache:master Dec 29, 2020
@shamrickus shamrickus mentioned this pull request Dec 31, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to automated testing/deployment/packaging etc. tests related to tests and/or testing infrastructure Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traffic Portal HTTP delivery service UI tests fail
4 participants