Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TP: adds tenant tree to replace flat, hard to visualize tenants table #5393

Merged
merged 12 commits into from
Dec 30, 2020
Merged

TP: adds tenant tree to replace flat, hard to visualize tenants table #5393

merged 12 commits into from
Dec 30, 2020

Conversation

mitchell852
Copy link
Member

@mitchell852 mitchell852 commented Dec 28, 2020 •
edited
Loading

What does this PR (Pull Request) do?

image

Also, added the ability to 'export CSV' so that functionality is preserved:

image

In addition, this PR provides the ability to view ALL delivery services accessible to a tenant OR only those directly assigned to the tenant.

image

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

  • Run UI tests
  • Navigate to https://tp.domain.tld/#!/tenants and interact with the tenancy tree (that replaced the flat table). I.e. expand/collapse nodes, add and delete tenants.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@mitchell852 mitchell852 added Traffic Portal v1 related to Traffic Portal version 1 improvement The functionality exists but it could be improved in some way. labels Dec 28, 2020
@mitchell852 mitchell852 changed the title TP: adds tenant tree to replace flat table TP: adds tenant tree to replace flat, hard to visualize tenants table Dec 29, 2020
@mitchell852 mitchell852 marked this pull request as ready for review December 29, 2020 16:55
@mitchell852
Copy link
Member Author

rebased so this can benefit from the new TP E2E Tests / E2E_tests GHA. Thanks @shamrickus !

shamrickus
shamrickus approved these changes Dec 30, 2020
View reviewed changes
Copy link
Member

@shamrickus shamrickus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • New hierarchical view works
  • Able to export Tenants to csv
  • Can see assigned to and accessible to for Tenants

@ocket8888 ocket8888 merged commit 9a06d61 into apache:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamrickus shamrickus shamrickus approved these changes

Assignees
No one assigned
Labels
improvement The functionality exists but it could be improved in some way. Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TP: represent tenants as a hierarchical visualization rather than a flat list
3 participants
@mitchell852 @shamrickus @ocket8888