Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering returns ordered results #5471

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

mattjackson220
Copy link
Contributor

What does this PR (Pull Request) do?

This PR sorts the results from the /steering endpoint to be sorted alphabetically by delivery service

Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

do a GET on the /steering endpoint on all API versions and make sure that the results are always ordered the same.
Verify that unit and API tests still pass

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

no test or doc updates since this is a small bug fix

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

@mitchell852 mitchell852 added bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Router related to Traffic Router labels Jan 27, 2021
Copy link
Collaborator

@tcfdev tcfdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down proposed PR and ran locally. Confirmed the results were not sorted previously. Then verified that the results are returned in ascending alphabetical order every time with all results still appearing.

LGTM

@zrhoffman zrhoffman merged commit 613969f into apache:master Jan 28, 2021
@rawlinp rawlinp added this to the 5.1.0 milestone Feb 12, 2021
ocket8888 pushed a commit to ocket8888/trafficcontrol that referenced this pull request Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TO /api/x/steering output should be sorted
5 participants