Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming TP server columns for IPv4 address fields #5501

Merged
merged 6 commits into from Feb 8, 2021
Merged

Renaming TP server columns for IPv4 address fields #5501

merged 6 commits into from Feb 8, 2021

Conversation

rimashah25
Copy link
Contributor

@rimashah25 rimashah25 commented Feb 5, 2021 •
edited

What does this PR (Pull Request) do?

Which Traffic Control components are affected by this PR?

  • Traffic Portal

What is the best way to verify this PR?

Visual check on TP UI server page

image

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • I have explained why tests are unnecessary
  • This PR includes documentation
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

The PR doesn't have tests as the logic hasn't changed.

@rimashah25 rimashah25 marked this pull request as ready for review February 5, 2021 19:49
@mattjackson220 mattjackson220 added improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1 labels Feb 5, 2021
srijeet0406
srijeet0406 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@srijeet0406 srijeet0406 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Tested manually and made sure the fields appear with the correct names in TP.

@ocket8888 ocket8888 merged commit a724b60 into apache:master Feb 8, 2021
@rimashah25 rimashah25 deleted the improvement/CDN-12042 branch April 8, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srijeet0406 srijeet0406 srijeet0406 approved these changes

Assignees
No one assigned
Labels
improvement The functionality exists but it could be improved in some way. low impact affects only a small portion of a CDN, and cannot itself break one Traffic Portal v1 related to Traffic Portal version 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename TP server columns for IPv4 address fields
4 participants
@rimashah25 @srijeet0406 @ocket8888 @mattjackson220