Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Tomcat build lock #5553

Merged
merged 5 commits into from May 3, 2021
Merged

Conversation

smalenfant
Copy link
Contributor

What does this PR (Pull Request) do?

This removes the restrictions imposed in the past to "lock in" the Tomcat release for Traffic Router. This has been quite a bit of a problem in the past in production when downgrading/upgrading TR (rollback). We don't compile nor we change the Tomcat code. There shouldn't be a need for this except for having a required version installed.

There has been compatibility issues in the past. All code should be tested in the lab before going to production.

This will also allow to upgrade Tomcat in the field without recompiling Traffic Router.

  • This PR fixes is not related to any Issue

Which Traffic Control components are affected by this PR?

  • Traffic Router

What is the best way to verify this PR?

Making sure Traffic Router install and starts properly

If this is a bug fix, what versions of Traffic Control are affected?

This is not a bug

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

None yet

@smalenfant smalenfant marked this pull request as ready for review February 22, 2021 17:02
@rawlinp rawlinp added the Traffic Router related to Traffic Router label Feb 22, 2021
@smalenfant smalenfant marked this pull request as draft February 22, 2021 18:34
@smalenfant smalenfant marked this pull request as ready for review February 22, 2021 20:44
@zrhoffman
Copy link
Member

Notes (mainly for myself) about what this PR does:

Before this PR
[user@computer dir]$ rpm -qp --qf '%{release}\n' tomcat-9.0.43-1.3526335f.el8.x86_64.rpm
1.3526335f.el8
After this PR
[user@computer dir]$ rpm -qp --qf '%{release}\n' tomcat-9.0.43-1.el8.noarch.rpm
1.el8

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look fine, it just needs a changelog entry.

@zrhoffman zrhoffman merged commit c9794f9 into apache:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants