Added the ability to change a server capability name

[rimashah25]

What does this PR (Pull Request) do?

• This PR fixes Add the ability to change a server capability name #5479

Which Traffic Control components are affected by this PR?

• Documentation
• Traffic Ops
• Traffic Portal

What is the best way to verify this PR?

Method 1: curl PUT API end point `api/4.0/server_capabilities?name=<server_capability_name>

{"alerts":[{
    "text":"server capability was updated.",
    "level":"success"}],
  "response":{"RequestedName":"tar","name":"tar","lastUpdated":"2021-03-04 02:50:49+00"}
}

Method 2: Using TP's page for server capability to edit(update) the name and verify name was updated with right message

Method 3: Run TP's end to end test.

Method 4: Run TO's API-v4 test casse

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

• This PR includes tests
• This PR includes documentation
• This PR includes an update to CHANGELOG.md
• This PR includes any and all required license headers
• This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

Additional Information

[mitchell852]

TP code looks good!

[mitchell852]

I don't understand the RequestedName property of the PUT response. Is this something new we are doing?

[rimashah25]

I don't understand the RequestedName property of the PUT response. Is this something new we are doing?

Yes, so server_capability API uses CRUDer function. In CRUD Update, there is a function (SetKeys) that basically sets the name field (primary key) to that of the param key value. Due to which, we lose the new name (RequestedName) that the user is trying to change to. To ensure, we don't lose the new name and at the same time ensure CRUDer functionality says un-impacted, this new variable was introduced.

[ocket8888]

Yes, so server_capability API uses CRUDer function. In CRUD Update, there is a function (SetKeys) that basically sets the name field (primary key) to that of the param key value. Due to which, we lose the new name (RequestedName) that the user is trying to change to. To ensure, we don't lose the new name and at the same time ensure CRUDer functionality says un-impacted, this new variable was introduced.

Not that I think you need to/should do so in this PR, but this is something that would motivate me to rewrite the endpoint to not use the "CRUDer"

[rimashah25]

Yes, so server_capability API uses CRUDer function. In CRUD Update, there is a function (SetKeys) that basically sets the name field (primary key) to that of the param key value. Due to which, we lose the new name (RequestedName) that the user is trying to change to. To ensure, we don't lose the new name and at the same time ensure CRUDer functionality says un-impacted, this new variable was introduced.

Not that I think you need to/should do so in this PR, but this is something that would motivate me to rewrite the endpoint to not use the "CRUDer"

IMO, we should get rid of all CRUDer functionality. This PR is a good example of how we end up applying a bandaid to not impact existing functionality

[srijeet0406]

Code looks good. API/ unit tests passed. Verified manually that I could change the server capability name from the UI and the API. LGTM.

[ocket8888]

IMO, we should get rid of all CRUDer functionality. This PR is a good example of how we end up applying a bandaid to not impact exists functionality

I would love that. It's just hard to justify the time it would take to yank all of that stuff out.