Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TO Client api for Parameters Automation #5797

Merged
merged 28 commits into from May 20, 2021
Merged

Add TO Client api for Parameters Automation #5797

merged 28 commits into from May 20, 2021

Conversation

dmohan001c
Copy link
Contributor

@dmohan001c dmohan001c commented Apr 29, 2021 •
edited

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • Traffic Control Client
  • Traffic Ops
  • CI tests

What is the best way to verify this PR?

Execute all the Integration tests and make sure the tests passed.

The following criteria are ALL met by this PR

  • This PR includes tests OR I have explained why tests are unnecessary
  • This PR includes documentation OR I have explained why documentation is unnecessary
  • This PR includes an update to CHANGELOG.md OR such an update is not necessary
  • This PR includes any and all required license headers
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@dmohan001c dmohan001c marked this pull request as draft April 29, 2021 07:22
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure improvement The functionality exists but it could be improved in some way. labels Apr 30, 2021
@dmohan001c dmohan001c marked this pull request as ready for review May 4, 2021 11:50
@ocket8888 ocket8888 self-assigned this May 4, 2021
ocket8888
ocket8888 reviewed May 5, 2021
View reviewed changes
traffic_ops/v4-client/parameter.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
@dmohan001c dmohan001c marked this pull request as draft May 5, 2021 14:47
@dmohan001c dmohan001c marked this pull request as ready for review May 5, 2021 14:52
ocket8888
ocket8888 reviewed May 5, 2021
View reviewed changes
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
@dmohan001c dmohan001c marked this pull request as draft May 17, 2021 12:38
@dmohan001c dmohan001c marked this pull request as ready for review May 17, 2021 15:40
ocket8888
ocket8888 reviewed May 17, 2021
View reviewed changes
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v4/parameters_test.go Outdated Show resolved Hide resolved
@dmohan001c dmohan001c marked this pull request as draft May 18, 2021 04:25
@dmohan001c dmohan001c marked this pull request as ready for review May 18, 2021 05:22
@ocket8888 ocket8888 merged commit 4f6dc4f into apache:master May 20, 2021
@potiuk potiuk mentioned this pull request Jul 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

Assignees

@ocket8888 ocket8888

Labels
improvement The functionality exists but it could be improved in some way. tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dmohan001c @ocket8888 @mitchell852