Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.17 #6111

Merged
merged 28 commits into from Aug 17, 2021
Merged

Update Go version to 1.17 #6111

merged 28 commits into from Aug 17, 2021

Conversation

zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Aug 16, 2021

This PR

  • Makes the Is it time to update Go? GHA workflow update GO_VERSION before setting up the Go version specified in GO_VERSION
  • Makes the build-rpms GHA build the ATC builder images if the GO_VERSION has changed in the scope of the PR, or in the last commit if it's not being run on a PR
  • Updates the Go version to 1.17 and updates the golang.org/x/ dependencies.

See the Go 1.17 release notes for details.


Which Traffic Control components are affected by this PR?

  • CDN in a Box - Enroller
  • Grove
  • Traffic Control Client (Go)
  • Traffic Monitor
  • Traffic Ops
  • Traffic Ops ORT
  • Traffic Stats
  • CI tests for Go components

What is the best way to verify this PR?

Run unit tests and API tests

PR submission checklist

  • Existing tests are sufficient
  • The documentation pulls the Go version from GO_VERSION, no other documentation changes are necessary
  • This PR has a CHANGELOG.md entry
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman
Copy link
Member Author

Rebased to fix the changelog merge conflict

@ocket8888
Copy link
Contributor

t3c failure looks related to this PR and not spurious:

go: go.mod file not found in current directory or any parent directory; see 'go help modules'

@zrhoffman
Copy link
Member Author

t3c failure looks related to this PR and not spurious:

go: go.mod file not found in current directory or any parent directory; see 'go help modules'

That error always happened because go mod vendor was run before cding into the ATC directory. Once in the ATC directory, go get ./... was run instead (changed to go mod vendor in 516df79).

As reported in golang/go#45609, go mod reports no dependencies in symlinked directories, resulting in go mod vendor emptying out the vendor directory. Resolving the symlink when cding into the ATC directory in c931a5f.

@zrhoffman
Copy link
Member Author

zrhoffman commented Aug 17, 2021

Okay, the logic for whether to build or pull the builder images is working.

@zrhoffman
Copy link
Member Author

Now it's actually working.

@zrhoffman zrhoffman changed the title Update Go version to 1.16.7 Update Go version to 1.17 Aug 17, 2021
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM - I'll leave it open for a bit in case you take my advice and remove the double-documented typing, but if not I'll merge it anyway; it's not hurting anything.

.github/actions/build-rpms/build-rpms.sh Show resolved Hide resolved
@ocket8888 ocket8888 merged commit 750833c into apache:master Aug 17, 2021
@zrhoffman zrhoffman deleted the go-1.16.7 branch August 17, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants