New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Go version to 1.17 #6111
Conversation
Rebased to fix the changelog merge conflict |
t3c failure looks related to this PR and not spurious:
|
That error always happened because As reported in golang/go#45609, |
|
Now it's actually working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all LGTM - I'll leave it open for a bit in case you take my advice and remove the double-documented typing, but if not I'll merge it anyway; it's not hurting anything.
This PR
GO_VERSION
before setting up the Go version specified inGO_VERSION
golang.org/x/
dependencies.See the Go 1.17 release notes for details.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Run unit tests and API tests
PR submission checklist
GO_VERSION
, no other documentation changes are necessary