Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Oauth #6508

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Updated Oauth #6508

merged 1 commit into from
Jan 14, 2022

Conversation

mattjackson220
Copy link
Contributor

This PR updates the OAuth flow to verify URLs and to use api.handleErr instead of the deprecated method


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Verify that the OAuth login works as before and that it returns an internal server error for bad requests

If this is a bugfix, which Traffic Control versions contained the bug?

PR submission checklist

@mattjackson220 mattjackson220 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Jan 11, 2022
@zrhoffman zrhoffman added the authentication Relating to login, registration, passwords, tokens, etc. label Jan 12, 2022
@ocket8888 ocket8888 added this to the 5.1.5 milestone Jan 12, 2022
@zrhoffman zrhoffman modified the milestones: 5.1.6, 6.1.0 Jan 12, 2022
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit b558554 into apache:master Jan 14, 2022
ocket8888 pushed a commit that referenced this pull request Jan 19, 2022
(cherry picked from commit b558554)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
authentication Relating to login, registration, passwords, tokens, etc. bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants