TP: Add indicator to Delivery Services if they are a steering target #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamrickus
added
new feature
ocket8888
reviewed
Aug 26, 2022
experimental/traffic-portal/src/app/api/delivery-service.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/api/testing/delivery-service.service.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Sep 1, 2022
experimental/traffic-portal/src/app/api/delivery-service.service.ts
Outdated
Show resolved
Hide resolved
traffic_portal/app/src/common/service/utils/DeliveryServiceUtils.js
Outdated
Show resolved
Hide resolved
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
…pache#7036) * Audit fix and update version * Update TR Version * Version file too * Implement in tpv2 * Implement in tpv1 * Changelog * Upgrade node version * Remove unused archived dep, revert node change in GHA * Dont need this * Remove last ref * Add server dependencies so RPMBUILD succeeds * Run npm i manually * Code review * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2101 in TPv1 and 2.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Verify the tests pass. Confirm that in TPv2 an icon appears if a DS is the target of another. In TPv1 verify that on the table view, there is a new column added
Target For. On the DS detail view, verify in the Routing Config section there is a readonly input with the Steering Target and that it has an appropriate tooltip.PR submission checklist