Fix t3c for large number of added files #7069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes t3c-check-refs to accept the list of added files over stdin or the input file, instead of an arg. Also changes the corresponding t3c-apply call of check-refs to pass the list as input. Because many operating systems (including the supported CentOS Linux) have argument length limits, this caused t3c-check-refs and therefore t3c-apply to fail for large numbers of added files.
rob05c
added
bug
ocket8888
added
the
low impact
jpappa200
approved these changes
Sep 13, 2022
zrhoffman
reviewed
Sep 19, 2022
zrhoffman
approved these changes
Sep 19, 2022
zrhoffman
pushed a commit
to zrhoffman/trafficcontrol
that referenced
this pull request
Oct 2, 2022
Fixes t3c-check-refs to accept the list of added files over stdin or the input file, instead of an arg. Also changes the corresponding t3c-apply call of check-refs to pass the list as input. Because many operating systems (including the supported CentOS Linux) have argument length limits, this caused t3c-check-refs and therefore t3c-apply to fail for large numbers of added files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes t3c-check-refs to accept the list of added files over stdin or the input file, instead of an arg.
Also changes the corresponding t3c-apply call of check-refs to pass the list as input.
Because many operating systems (including the supported CentOS Linux) have argument length limits, this caused t3c-check-refs and therefore t3c-apply to fail for large numbers of added files.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
Run tests. Run t3c with a large number of newly-added files, verify it succeeds.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist
[x] This PR has testsFunctionality is tested in numerous existing tests.