Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ASN from servers #7118

Merged
merged 4 commits into from Oct 20, 2022
Merged

Remove ASN from servers #7118

merged 4 commits into from Oct 20, 2022

Conversation

srijeet0406
Copy link
Contributor

@srijeet0406 srijeet0406 commented Oct 11, 2022 •
edited

This PR is not related to any issue. It removes the previously added (in #7023) asns field from the server struct.

Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Control Client
  • Traffic Ops
  • Traffic Portal
  • CDN in a Box

What is the best way to verify this PR?

Make sure you don't see the asns field in GET calls that return the server object.
Make sure all tests pass.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 added Traffic Ops related to Traffic Ops Traffic Portal related to Traffic Portal documentation related to documentation unused code Code that can be removed due to no longer being used labels Oct 11, 2022
@ocket8888 ocket8888 added the low impact affects only a small portion of a CDN, and cannot itself break one label Oct 11, 2022
@ocket8888 ocket8888 self-assigned this Oct 11, 2022
@ocket8888 ocket8888 self-requested a review October 20, 2022 16:59
ocket8888
ocket8888 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ocket8888 ocket8888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed ASN from every server representation I can think of

@ocket8888 ocket8888 merged commit bd6f7ee into apache:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocket8888 ocket8888 ocket8888 approved these changes

Assignees

@ocket8888 ocket8888

Labels
documentation related to documentation low impact affects only a small portion of a CDN, and cannot itself break one Traffic Ops related to Traffic Ops Traffic Portal related to Traffic Portal unused code Code that can be removed due to no longer being used
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srijeet0406 @ocket8888