Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Generics in TO Integration Tests #7144

Merged
merged 14 commits into from Oct 20, 2022
Merged

Use Generics in TO Integration Tests #7144

merged 14 commits into from Oct 20, 2022

Conversation

ericholguin
Copy link
Contributor

Updated the tests to use the new generics test struct

Which Traffic Control components are affected by this PR?

  • Traffic Ops Tests

What is the best way to verify this PR?

Run TO Integration Tests

PR submission checklist

@ericholguin ericholguin changed the title Updating tests to use generics continued Use Generics in TO Integration Tests Oct 17, 2022
@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure tech debt rework due to choosing easy/limited solution labels Oct 17, 2022
zrhoffman
zrhoffman requested changes Oct 20, 2022
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just a few small things

traffic_ops/testing/api/v4/server_server_capabilities_test.go Show resolved Hide resolved
traffic_ops/testing/api/v5/servers_hostname_update_status_test.go Outdated Show resolved Hide resolved
traffic_ops/testing/api/v5/servers_id_queue_update_test.go Outdated Show resolved Hide resolved
zrhoffman
zrhoffman approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zrhoffman zrhoffman merged commit 736b5d5 into apache:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zrhoffman zrhoffman zrhoffman approved these changes

Assignees
No one assigned
Labels
tech debt rework due to choosing easy/limited solution tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ericholguin @zrhoffman