Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "twelve" as the password where "twelve12" was used #7149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zrhoffman
Copy link
Member

#4764 changed the default password in some places, but not all, from twelve to twelve12. This is confusing for all of the people who are used to twelve being the default password for all components of the project. This PR reverts all instances of twelve12 to twelve.


Which Traffic Control components are affected by this PR?

  • CDN in a Box
  • CDN in a Box for Developers
  • Traffic Portal
  • Traffic Portal v2

What is the best way to verify this PR?

Verify the tests pass

PR submission checklist

@zrhoffman zrhoffman added Traffic Portal related to Traffic Portal tests related to tests and/or testing infrastructure cdn-in-a-box related to the Docker-based CDN-in-a-Box system improvement The functionality exists but it could be improved in some way. dev-ciab Related to CDN in a Box for Developers Traffic Portal v2 Related to the experimental Traffic Portal v2 labels Oct 19, 2022
@zrhoffman zrhoffman mentioned this pull request Oct 19, 2022
4 tasks
@ocket8888
Copy link
Contributor

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

@mitchell852
Copy link
Member

mitchell852 commented Nov 28, 2023

how about using password as the password? that meets the 8 character requirement. this is just used for cdn in a box, right?

@zrhoffman
Copy link
Member Author

I don't agree that we should knowingly use invalid data in any environment, except in a test to ensure such data is rejected by the API.

twelve12 is in invalid_passwords.txt (as is twelve), it would be rejected by the API. But using twelve12 detracts from usability, and keeping twelve does not.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a3e1e0) 28.96% compared to head (e2ebbce) 65.64%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@              Coverage Diff              @@
##             master    #7149       +/-   ##
=============================================
+ Coverage     28.96%   65.64%   +36.68%     
  Complexity       98       98               
=============================================
  Files           602      323      -279     
  Lines         77452    12836    -64616     
  Branches         90      970      +880     
=============================================
- Hits          22432     8426    -14006     
+ Misses        52926     4050    -48876     
+ Partials       2094      360     -1734     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 74.35% <100.00%> (?)
traffic_stats_unit ?
unit_tests 74.35% <100.00%> (+48.55%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ocket8888
Copy link
Contributor

If twelve12 would be rejected by the API then it shouldn't be in use either. It does, at least, meet the requirements in TP(v1), but really we should have a password that will be accepted. Like twelve12! (I hope; I didn't check).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cdn-in-a-box related to the Docker-based CDN-in-a-Box system dev-ciab Related to CDN in a Box for Developers improvement The functionality exists but it could be improved in some way. tests related to tests and/or testing infrastructure Traffic Portal v2 Related to the experimental Traffic Portal v2 Traffic Portal related to Traffic Portal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants