New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retract versions v1.1.0 through v1.1.5 from Go modules #7150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
tech debt
rework due to choosing easy/limited solution
improvement
The functionality exists but it could be improved in some way.
process
go
Pull requests that update Go or Go-related code
labels
Oct 20, 2022
We could also tag it something like |
zrhoffman
force-pushed
the
retract-v1
branch
from
November 15, 2022 22:55
ef64d37
to
1f9de94
Compare
Rebased onto latest master |
zrhoffman
force-pushed
the
retract-v1
branch
from
November 16, 2022 19:25
dc4428d
to
7d108a7
Compare
Rebased to get the t3c test nonbreakage from #7198 |
ocket8888
approved these changes
Nov 17, 2022
rimashah25
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Use :atc-godoc: role instead of pkg.go.dev URLs * Update module path to v8 in non-golang files git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Update module path to v8 in golang sources git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Revert "Retract versions v1.1.0 through v1.1.5 from Go modules (#7150)" This reverts commit 83255a7. * Update module version to v8
rimashah25
pushed a commit
that referenced
this pull request
Sep 22, 2023
* Use :atc-godoc: role instead of pkg.go.dev URLs * Update module path to v8 in non-golang files git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Update module path to v8 in golang sources git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Revert "Retract versions v1.1.0 through v1.1.5 from Go modules (#7150)" This reverts commit 83255a7. * Update module version to v8 (cherry picked from commit 0115c92)
jpappa200
pushed a commit
to jpappa200/trafficcontrol
that referenced
this pull request
Sep 27, 2023
* Use :atc-godoc: role instead of pkg.go.dev URLs * Update module path to v8 in non-golang files git ls-files | grep -vE '^CHANGELOG|^vendor|\.go$' | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Update module path to v8 in golang sources git ls-files '**.go' | grep -vE ^vendor | xargs grep -lE '[^/]github\.com/apache/trafficcontrol/' | xargs sed -Ei 's|([^/]github\.com/apache/trafficcontrol/)|\1v8/|g' * Revert "Retract versions v1.1.0 through v1.1.5 from Go modules (apache#7150)" This reverts commit 83255a7. * Update module version to v8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
go
Pull requests that update Go or Go-related code
improvement
The functionality exists but it could be improved in some way.
process
tech debt
rework due to choosing easy/limited solution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR retracts
v1.1.0
,v1.1.1
,v1.1.2
,v1.1.3
,v1.1.4
, andv1.1.5-retractions
from Go modules. If this PR is merged, it should be tagged versionv1.1.5-retractions
.Without this PR and tag
v1.1.5-retractions
, a user runningwill retrieve dependency
github.com/apache/trafficcontrol
at versionv1.1.4-0.20201118150121-817a702a9de6
. With this PR merged and taggedv1.1.5-retractions
, the samego get
command will yield versionv0.0.0-20201118150121-817a702a9de6
.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
In a different window, try getting a 4.1.x commit:
mkdir my-project cd my-project go mod init my-project go get github.com/my-fork/nonfork@817a702a9d
Expected computed version:
v1.1.4-0.20201118150121-817a702a9de6
Back in the first window, retract v1:
Back in the
my-project
window, try importing the 4.1.x commit again:sudo rm -rf ${GOPATH}/pkg go get github.com/my-username/nonfork@817a702a9de6
Expected computed version:
v0.0.0-20201118150121-817a702a9de6
PR submission checklist