New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix APIv4.0 returning APIv4.1 DS structures #7156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready to merge, just 1 comment
1450645
to
6c53292
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API tests fail
--- FAIL: TestDeliveryServices (4.98s)
--- FAIL: TestDeliveryServices/GET (0.01s)
--- FAIL: TestDeliveryServices/GET/OK_when_VALID_XMLID_parameter (0.01s)
panic: interface conversion: interface {} is []tc.DeliveryServiceV41, not []tc.DeliveryServiceV40 [recovered]
panic: interface conversion: interface {} is []tc.DeliveryServiceV41, not []tc.DeliveryServiceV40
traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR fixes a bug introduced by #7111 where APIv4.0 responses containing representations of Delivery Services used the representation from APIv4.1.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests still pass, request Delivery Services at APIv4.0 and observe no
regional
property, then again at APIv4.1 and observe that it now does have the v4.1regional
property.If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist