Fix TR logging when cqhv field is absent #7340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7340 +/- ##
=========================================
Coverage 25.02% 25.02%
Complexity 98 98
=========================================
Files 593 593
Lines 73528 73528
Branches 90 90
=========================================
Hits 18398 18398
Misses 53383 53383
Partials 1747 1747
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zrhoffman
requested changes
Feb 2, 2023
...rc/main/java/org/apache/traffic_control/traffic_router/core/http/HTTPAccessEventBuilder.java
Outdated
Show resolved
Hide resolved
zrhoffman
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It adds the "-" default value for the "cqhv" field, when it is absent.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests pass.
Send in a request with the protocol set to null or an empty string and make sure the logs show cqhv="-".
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist