Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed for app locking issues #7352

Merged
merged 2 commits into from Feb 16, 2023
Merged

fixed for app locking issues #7352

merged 2 commits into from Feb 16, 2023

Conversation

jpappa200
Copy link
Contributor

Currently the file locking is not working correctly and will only pause for one second and then continue. This allows for multiply instances t3c-apply to run at one time. This change will prevent that and log when retries when attempting to get application lock.


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

The best way to test is to build t3c, install on a cache. Queue updates, and in 2 separate terminals kick off t3c at the same time. You should see one run ant the other waiting to get application lock.

If this is a bugfix, which Traffic Control versions contained the bug?

  • 7.0.1 and before

PR submission checklist

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #7352 (941cfb2) into master (dad5772) will decrease coverage by 0.79%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #7352      +/-   ##
============================================
- Coverage     25.06%   24.27%   -0.79%     
  Complexity       98       98              
============================================
  Files           593      337     -256     
  Lines         73644    43097   -30547     
  Branches         90       90              
============================================
- Hits          18459    10463    -7996     
+ Misses        53434    31755   -21679     
+ Partials       1751      879     -872     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit 19.70% <ø> (ø)
traffic_stats_unit ?
unit_tests 19.70% <ø> (-2.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cache-config/t3c-apply/t3c-apply.go
lib/go-util/net.go
grove/lru/lru.go
cache-config/t3cutil/toreq/torequtil/torequtil.go
grove/plugin/http_cacheinspector.go
lib/go-util/ptr.go
lib/go-atscfg/strategiesdotconfig.go
lib/go-atscfg/snidotyaml.go
grove/grove.go
traffic_monitor/config/staticappdata.go
... and 247 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good.

@ocket8888 ocket8888 added bug something isn't working as intended low impact affects only a small portion of a CDN, and cannot itself break one cache-config Cache config generation labels Feb 16, 2023
@ocket8888 ocket8888 merged commit 5335f80 into apache:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended cache-config Cache config generation low impact affects only a small portion of a CDN, and cannot itself break one
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants