Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed t3c for layered profile order issue #7425

Merged
merged 4 commits into from Mar 31, 2023

Conversation

jpappa200
Copy link
Contributor

when layered profiles are used, t3c was not iterating through the profiles in the proper order,
which was causing duplicate parameters to be incorrectly overridden


Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)

What is the best way to verify this PR?

run the unit test for layered profiles, otherwise build and install t3c setup layered profiles on a cache and
have 2 or more parameters with the same config file and name but different values. run t3c and verify
duplicate parameters have been overridden by the profile with the highest priority.

If this is a bugfix, which Traffic Control versions contained the bug?

  • trafficcontrol-cache-config-7.1.0-12303.79ed7a01

PR submission checklist

Copy link
Contributor

@traeak traeak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixes look good and just reverse the profile evaluation (not that i like the back to front eval but that ship has sailed).

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #7425 (b72c798) into master (f7765ff) will increase coverage by 0.01%.
The diff coverage is 86.66%.

@@             Coverage Diff              @@
##             master    #7425      +/-   ##
============================================
+ Coverage     27.03%   27.04%   +0.01%     
  Complexity       98       98              
============================================
  Files           685      685              
  Lines         77279    77301      +22     
  Branches         90       90              
============================================
+ Hits          20892    20908      +16     
- Misses        54399    54405       +6     
  Partials       1988     1988              
Flag Coverage Δ
golib_unit 48.39% <86.66%> (+0.04%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.32% <ø> (ø)
traffic_monitor_unit 20.43% <ø> (ø)
traffic_ops_unit 22.19% <ø> (ø)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 23.60% <86.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/go-atscfg/parentdotconfig.go 65.22% <85.00%> (+0.29%) ⬆️
lib/go-atscfg/atscfg.go 58.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman merged commit 3f94fdc into apache:master Mar 31, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants