Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Portal v2 Topologies details page #7615

Merged
merged 14 commits into from
Aug 1, 2023

Conversation

zrhoffman
Copy link
Member

@zrhoffman zrhoffman commented Jul 5, 2023

This PR adds the Topologies details page to Traffic Portal v2 with the following restrictions:

  • The UI does not yet let you rearrange the cachegroups
  • The UI does not yet let you add cachegroups
  • The UI does not yet let you remove cachegroups

Depends on apache/trafficcontrol-trafficops-types#4 (merged)


Which Traffic Control components are affected by this PR?

  • Traffic Portal v2

PR submission checklist

@zrhoffman zrhoffman added new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2 labels Jul 5, 2023
@ocket8888 ocket8888 added low impact affects only a small portion of a CDN, and cannot itself break one experimental a feature/component not directly supported by ATC labels Jul 5, 2023
@ocket8888 ocket8888 added this to In progress in TPv2 via automation Jul 5, 2023
@ocket8888 ocket8888 self-assigned this Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #7615 (4fbced1) into master (33d8179) will increase coverage by 38.12%.
Report is 1 commits behind head on master.
The diff coverage is 59.86%.

@@              Coverage Diff              @@
##             master    #7615       +/-   ##
=============================================
+ Coverage     28.97%   67.09%   +38.12%     
  Complexity       98       98               
=============================================
  Files           739      266      -473     
  Lines         82332    10130    -72202     
  Branches        908      952       +44     
=============================================
- Hits          23855     6797    -17058     
+ Misses        56435     3061    -53374     
+ Partials       2042      272     -1770     
Flag Coverage Δ
golib_unit ?
grove_unit ?
t3c_unit ?
traffic_monitor_unit ?
traffic_ops_unit ?
traffic_portal_v2 73.69% <59.86%> (-0.24%) ⬇️
traffic_stats_unit ?
unit_tests 73.69% <59.86%> (+46.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...fic-portal/src/app/api/testing/topology.service.ts 10.81% <10.81%> (ø)
...ies/topology-details/topology-details.component.ts 55.17% <55.17%> (ø)
...tal/traffic-portal/src/app/api/topology.service.ts 100.00% <100.00%> (ø)

... and 489 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zrhoffman zrhoffman requested a review from ocket8888 July 13, 2023 16:00
TPv2 automation moved this from In progress to Review in progress Jul 17, 2023
@zrhoffman zrhoffman requested a review from ocket8888 July 28, 2023 19:41
@zrhoffman
Copy link
Member Author

Rebased onto master

@zrhoffman zrhoffman requested a review from ocket8888 July 31, 2023 22:54
TPv2 automation moved this from Review in progress to Reviewer approved Aug 1, 2023
@ocket8888 ocket8888 merged commit 1193ccb into apache:master Aug 1, 2023
9 checks passed
TPv2 automation moved this from Reviewer approved to Done Aug 1, 2023
@zrhoffman zrhoffman deleted the tpv2-topologies-details branch August 1, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental a feature/component not directly supported by ATC low impact affects only a small portion of a CDN, and cannot itself break one new feature A new feature, capability or behavior Traffic Portal v2 Related to the experimental Traffic Portal version 2
Projects
TPv2
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants