Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed TryIfModifiedSinceQuery from servicecategories.go and reused from ims.go #7623

Merged

Conversation

jagan-parthiban
Copy link
Contributor

Closes: No related Issues


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

The Get request to service_category api with If-Modified-Since should return 304.

curl --request GET \
  --url https://localhost:8443/api/5.0/service_categories \
  --header 'If-Modified-Since: Mon, 04 Jul 2024 18:00:00 IST'

If this is a bugfix, which Traffic Control versions contained the bug?

  • 7.0.1

PR submission checklist

@jagan-parthiban jagan-parthiban marked this pull request as ready for review July 9, 2023 05:07
@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #7623 (30a5dcb) into master (c36c7b0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #7623      +/-   ##
============================================
- Coverage     30.13%   30.12%   -0.01%     
  Complexity       98       98              
============================================
  Files           794      794              
  Lines         84106    84067      -39     
  Branches        907      907              
============================================
- Hits          25344    25329      -15     
+ Misses        56634    56608      -26     
- Partials       2128     2130       +2     
Flag Coverage Δ
golib_unit 48.29% <ø> (ø)
grove_unit 4.60% <ø> (ø)
t3c_unit 5.28% <ø> (ø)
traffic_monitor_unit 21.30% <ø> (ø)
traffic_ops_integration 69.42% <ø> (ø)
traffic_ops_unit 22.95% <100.00%> (-0.02%) ⬇️
traffic_portal_v2 73.78% <ø> (ø)
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 27.25% <100.00%> (-0.01%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ic_ops_golang/servicecategory/servicecategories.go 10.21% <100.00%> (-6.46%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jagan-parthiban jagan-parthiban force-pushed the improve/rfc3339-service-category-redo branch from 7390d5f to 30a5dcb Compare July 9, 2023 07:27
Copy link
Contributor

@rimashah25 rimashah25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimashah25 rimashah25 merged commit 47596b0 into apache:master Jul 10, 2023
41 of 42 checks passed
@jagan-parthiban jagan-parthiban deleted the improve/rfc3339-service-category-redo branch July 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants