Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim whitespace before comparing certificate chains #7628

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

zrhoffman
Copy link
Member

This PR fixes an issue where SSL certificate chain validation fails if the chain does not end with a newline.

This PR also fixes an issue where TO would return a 500 ISE if certificate verification passes.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

  1. Submit chain that is not modified during verification
  2. Make sure verification passes

If this is a bugfix, which Traffic Control versions contained the bug?

6.1.0

7.0.0

PR submission checklist

@zrhoffman zrhoffman added Traffic Ops related to Traffic Ops SSL support for/problems with SSL features labels Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #7628 (f6a1a56) into master (dcf6e31) will increase coverage by 0.00%.
The diff coverage is 66.66%.

❗ Current head f6a1a56 differs from pull request most recent head c4a1143. Consider uploading reports for the commit c4a1143 to get more accurate results

@@            Coverage Diff            @@
##             master    #7628   +/-   ##
=========================================
  Coverage     30.12%   30.13%           
  Complexity       98       98           
=========================================
  Files           794      794           
  Lines         84072    84075    +3     
  Branches        907      907           
=========================================
+ Hits          25329    25332    +3     
+ Misses        56613    56612    -1     
- Partials       2130     2131    +1     
Flag Coverage Δ
golib_unit 48.30% <ø> (+<0.01%) ⬆️
grove_unit 4.60% <ø> (ø)
t3c_unit 5.28% <ø> (ø)
traffic_monitor_unit 21.30% <ø> (ø)
traffic_ops_unit 22.96% <66.66%> (+<0.01%) ⬆️
traffic_portal_v2 73.76% <ø> (-0.03%) ⬇️
traffic_stats_unit 10.14% <ø> (ø)
unit_tests 27.25% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...fic_ops/traffic_ops_golang/deliveryservice/keys.go 31.97% <66.66%> (+0.37%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srijeet0406 srijeet0406 merged commit d48a57a into apache:master Jul 10, 2023
39 of 40 checks passed
@zrhoffman zrhoffman deleted the trim-chains-whitespace branch July 10, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SSL support for/problems with SSL features Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants