Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Router: Set "minimum" for SOA records to a custom value defined by a parameter #7808

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

srijeet0406
Copy link
Contributor

@srijeet0406 srijeet0406 commented Sep 21, 2023

This PR is not related to any issue. It sets the SOA minimum to a custom value, when Traffic Router populates the auto-zones files.


Which Traffic Control components are affected by this PR?

  • Documentation
  • Traffic Router

What is the best way to verify this PR?

Run your local TR
Make DNS queries for valid and invalid FQDNs and ensure that the "minimum" returned in the SOA records is the custom value that you set the "dns.negative.caching.ttl" parameter in CRConfig.json to.

If this is a bugfix, which Traffic Control versions contained the bug?

  • master

PR submission checklist

@srijeet0406 srijeet0406 changed the title initial commit Traffic Router: Set "minimum" for SOA records to a custom value defined by a parameter Sep 21, 2023
@srijeet0406 srijeet0406 marked this pull request as ready for review September 21, 2023 22:07
@srijeet0406 srijeet0406 added new feature A new feature, capability or behavior Traffic Router related to Traffic Router labels Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #7808 (a61eb7c) into master (9cfe018) will not change coverage.
Report is 8 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #7808   +/-   ##
=========================================
  Coverage     31.83%   31.83%           
  Complexity       98       98           
=========================================
  Files           717      717           
  Lines         82720    82720           
  Branches        965      965           
=========================================
  Hits          26338    26338           
  Misses        54217    54217           
  Partials       2165     2165           
Flag Coverage Δ
traffic_router_unit 29.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@zrhoffman zrhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@zrhoffman zrhoffman merged commit 4808c81 into apache:master Sep 26, 2023
20 checks passed
jpappa200 pushed a commit to jpappa200/trafficcontrol that referenced this pull request Sep 27, 2023
…ed by a parameter (apache#7808)

* initial commit

* set param to dns neg ttl

* adding changelog

* change param name

* fix tests

* modify changelog

* fix pmd

* code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature, capability or behavior Traffic Router related to Traffic Router
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants